Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: Remove wallet RPC stakepooluserinfo. #3439

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

jholdstock
Copy link
Member

Can be merged if/when decred/dcrwallet#2403 is merged.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll wait to approve depending on the results of the PR it depends on.

@jrick
Copy link
Member

jrick commented Sep 6, 2024

ticketsforaddress should also be removed.

@jholdstock
Copy link
Member Author

dcrd has its own implementation of ticketsforaddress

@davecgh
Copy link
Member

davecgh commented Sep 7, 2024

dcrd has its own implementation of ticketsforaddress

Yeah, but he means from the rpcAskWallet map. The dcrd one is in the rpcHandlersBeforeInit map which rpcHandlers is set to at init time.

This RPC has been removed from dcrwallet, thus no longer needs to be
listed by dcrd as an "rpcAskWallet" command.
This RPC has been removed from dcrwallet, thus no longer needs to be
listed by dcrd as an "rpcAskWallet" command.
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the requisite PR is going to be merged soon, so approving.

@davecgh davecgh added this to the 2.1.0 milestone Sep 7, 2024
@davecgh davecgh added the rpc server api change Issues and/or pull requests that involve a new RPC server version or breaking to change to the API. label Sep 7, 2024
@davecgh davecgh merged commit a032497 into decred:master Sep 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc server api change Issues and/or pull requests that involve a new RPC server version or breaking to change to the API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants