Fix grpc reconnection and add /info endpoint #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable querying the server for this information without having to also decode it somewhere else.
This returns information about the managed channels.
Only accesses from localhost (considering reverse-proxied requests) are allowed.
This fixes the server's Run method to properly attempt reconnections to the dcrlnd node in case of errors. Previously, two things were wrong in this method: - The context used in some calls was ctx instead of gctx, which caused some of the subsystems to not exit correctly on failures and thus mask the underlying connection error. - There was no re-attempt at failed operations, when the reason for failure was a connection error (as opposed to a graceful termination of the server). This commit fixes both issues by using the correct context everywhere and ensuring all subsystems re-attempt their functions until the context is canceled, with an appropriate delay.
dajohi
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /info endpoint is meant to offer information about the server's management of the channels to the operator. It should only be accessible from localhost.
This also fixes the gRPC connection issue #17.