multi: store unencrypted scripts in address mgr. #1500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
script_storage_upgrade
branch
from
b734346 to
be6405a
Compare
dnldd
force-pushed
the
script_storage_upgrade
branch
from
be6405a to
16ecf0a
Compare
jrick
reviewed
Aug 2, 2019
dnldd
force-pushed
the
script_storage_upgrade
branch
from
16ecf0a to
46d7421
Compare
dnldd
changed the title
dnldd
force-pushed
the
script_storage_upgrade
branch
from
46d7421 to
a7c5bb5
Compare
jrick
reviewed
Aug 13, 2019
This allows storing unencrypted script addresses in the address manager. This behaviour will become default after the wallet is upgraded.
dnldd
force-pushed
the
script_storage_upgrade
branch
from
a7c5bb5 to
83bf984
Compare
|
I took a closer look at the project's history, and since the mainnet launch, dcrwallet has always stored all imported scripts both encrypted and unencrypted. So I'm thinking we can do this upgrade a lot cleaner by simply copying the unencrypted script in a db upgrade instead of changing the db schema. This will be far preferred over saving either encrypted or unencrypted scripts in the address manager buckets. Closing this PR as it's outdated and not the most straightforward fix here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #1497
This allows storing unencrypted script addresses in the address manager by modifying the address row serialization to track which entries are encrypted/raw. Storing raw scripts will become default behaviour after the wallet is upgraded.