Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

news: Add 10 items #1135

Merged
merged 2 commits into from
Aug 31, 2023
Merged

news: Add 10 items #1135

merged 2 commits into from
Aug 31, 2023

Conversation

xaur
Copy link
Contributor

@xaur xaur commented Aug 29, 2023

  • Add 2 Bison Relay non-RC releases
  • Add 4 Decred Journal issues
  • Add 4 Coverage items
    • Selection criteria used is "anything notable, ideally involving people/orgs external to Decred"
  • Fix dead decredmagazine.com links to cypherpunktimes.com
    • Not expecting the redirects will be fixed anytime soon

I still don't have a good rule to follow for choosing which icon to use. If anyone has one, please open an issue, tag me and I will apply it to make our news icons consistent.

- Add 2 Bison Relay non-RC releases
- Add 4 Decred Journal issues
- Add 4 Coverage items
  - Selection criteria used is "anything notable, ideally involving
    people/orgs external to Decred"
- Fix dead decredmagazine.com links to cypherpunktimes.com
  - Not expecting the redirects will be fixed anytime soon

I still don't have a good rule to follow for choosing which `icon` to
use. If anyone has one, please open an issue, tag me and I will apply
it to make our news icons consistent.
src/data/news/decred_journals.yml Outdated Show resolved Hide resolved
@jholdstock
Copy link
Member

re: icons
#1099 (review)

@xaur
Copy link
Contributor Author

xaur commented Aug 31, 2023

re: icons #1099 (review)

Thanks for the link. Now I see what confused me back then and now again. The problem starts in the original categorization in #561: the Broadcast, streams, videos class in "Community", and Decred in media and Press releases, interviews classes in "Media and Events" all overlap. One news item can be all of: a (live)stream, a video, something "in the media", and an interview. Then the informal "broadcasts.svg for video interviews and interview.svg for audio only" is also confusing to me. Most other icons/categories do not have this problem.

For this PR I changed "Quantum and Cryptocurrency" to interview.svg because it's kind of an interview. Keeping "The Future Is Now" as dcrInMedia.svg because even though it's an interview, the microphone icon of interview.svg implies audio. Keeping the remaining two as broadcasts.svg because "broadcast" sounds like "live stream".

In the future I hope we'll define better semantics for these icons, rename them, and maybe change 1-2 icons to avoid confusion and time loss.

@xaur
Copy link
Contributor Author

xaur commented Aug 31, 2023

Please remind me should I squash or do you guys squash when merging?

@jholdstock
Copy link
Member

In simple cases like this its easy to squash with GitHub. A repo maintainer may ask you to squash manually in more complicated cases so it can be done more carefully - eg. if a series of commits depend on eachother, or if their messages contain important context which may need to be updated.

@jholdstock jholdstock merged commit 79d5885 into decred:master Aug 31, 2023
2 checks passed
@xaur xaur deleted the news202308 branch November 6, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants