Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cms] Fix the update of empty user owned proposals and supervisors #1267

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thi4go
Copy link
Member

@thi4go thi4go commented Jul 30, 2020

This diff solves a misbehaviour where we couldn't set the owned proposals and supervisors id fields back to empty. Now we check the updated fields agains't the previous records to see if there was any changes, and if so, continue with the update.

@alexlyp
Copy link
Member

alexlyp commented Jul 31, 2020

So change look ok I think, but we need to make sure now that cmswww or gui sends the value of the supervisorid or proposals owned field, since if they are empty on the request they will be cleared in the db

@thi4go
Copy link
Member Author

thi4go commented Jul 31, 2020

Hey mate @alexlyp good point. Updated cmswww to send the previous user details for supervisorsIds and proposalsOwned if they were not set in the cmd.

Will make sure that politeiagui does the same now 👍

@thi4go thi4go changed the title [cms] Fix the update of empty user owned proposals and supervisors wip: [cms] Fix the update of empty user owned proposals and supervisors Jul 31, 2020
@thi4go
Copy link
Member Author

thi4go commented Aug 12, 2020

For the record, as per this discussion on riot, it was decided to create a custom action provider for the cms manage user route. Now, more complex fields to deal with like supervisor ids and proposals owned, can use them to be handled with more simplicity.

@thi4go thi4go changed the title wip: [cms] Fix the update of empty user owned proposals and supervisors [cms] Fix the update of empty user owned proposals and supervisors Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants