Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Tests 4 recipe module #8

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

WIP: Tests 4 recipe module #8

wants to merge 12 commits into from

Commits on Sep 4, 2020

  1. Create FactoryBot Class

    dede999 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    6b0b48e View commit details
    Browse the repository at this point in the history
  2. Improve code's quality

    By removing a useless junk of code, I improved my code's quality
    dede999 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    798f79c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    62ad92d View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. Configuration menu
    Copy the full SHA
    a6c50ff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    abf9dbe View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Configuration menu
    Copy the full SHA
    33e0038 View commit details
    Browse the repository at this point in the history
  2. Refactor recipe.service.ts

    There were some variables that didn't have much
    use. They were assigned and returned. Assuming
    is not nice to have these kind of variables, I
    removed them
    dede999 committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f302a18 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Create mongoose shared examples

    In order to get my tests DRY, I created a file
    where I could place describe scenarios I could
    reproduce avoiding code repetition.
    
    Moreover, there are some changes associated with
    linting
    dede999 committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0af1870 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Complete test for recipe.service.spec.ts

    Besides the tests, I managed to do it with less
    repeated code, thanks to Jay (jmcdo29) that helped
    me a lot showing his code.
    
    After completing my issues, I'll probably try to
    improve these tests
    dede999 committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    a28d0d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Refactor recipe.controller.ts

    There was a wrong thing in the controller. In some methods,
    if the answer was not a truthy value, we would have a thrown
    exception. Point is that, it would never be falsey value, and
    mocking it could result in false positive test returns. In
    order to correct it, that check has been removed.
    
    Besides, allRecipe was redundant. If it had an empty object
    as a parameter, it would return allRecipes value, otherwise
    it would return filterRecipes value. Problem is that filter
    method already returns allRecipes if an empty object is
    passed. This was corrected by removing the conditional, and
    returning filterRecipes value
    dede999 committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    8846e8e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Re-design deleteRecipe

    Inspired by Jay's code again, I've changed the deletion method.
    It was not wrong before, but now it's a clearer code, and the
    service became a little easier to test
    dede999 committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    52fa094 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2a1583 View commit details
    Browse the repository at this point in the history