Add check for the dkg public key after resharing #491
Conversation
|
|
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
|
Please add a description in the PR. |
|
Added. |
|
And you need to sign the CLA, if I read the failing tests correctly... |
|
In particular, regarding the CLA, it seems the e-mail/username you used as part of your commit (litiange) is not associated with your GitHub account. This is why the CLA automation can't detect whether you've signed it already or not. |
| @@ -667,6 +667,10 @@ func TestDKGResharing(t *testing.T) { | |||
| newSecret, err := share.RecoverSecret(suite, newSShares, thr, defaultN) | |||
| require.NoError(t, err) | |||
| require.Equal(t, oldSecret.String(), newSecret.String()) | |||
| // 3. | |||
| for i := 0; i < len(dkgs); i++ { | |||
| require.Equal(t, shares[i].Public(), newShares[i].Public()) | |||
There was a problem hiding this comment.
the overall DKG public key should remain constant, not the public key of each share, right ?
There was a problem hiding this comment.
That's correct, but the Public() method returns the public key of the distributed key:
kyber/share/dkg/pedersen/structs.go
Line 24 in a008b2d
So this should pass.
|
As stated in the related issue, this check has been added when we merged DRAND version of this pedersen dkg, thanks for your work ! |
Check whether the DKG public key changes before and after resharing among the same group of nodes.
Closes #489