Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified 32-bit fail fix #529

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Simplified 32-bit fail fix #529

merged 1 commit into from
Jun 12, 2024

Conversation

matteosz
Copy link
Contributor

@matteosz matteosz commented Jun 9, 2024

This PR is a simplification for #502 . The error was due to the protobuf decoding of an int field in the PriShare struct, only changing that field should solve the issue and minimise the risk since the changes are now minimal.

@matteosz matteosz self-assigned this Jun 9, 2024
@matteosz matteosz changed the base branch from master to drandmerge June 9, 2024 17:09
@matteosz matteosz closed this Jun 9, 2024
@matteosz matteosz reopened this Jun 9, 2024
Copy link

sonarcloud bot commented Jun 9, 2024

Copy link
Contributor

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy with it I guess because now some indices are uint32 and some are int, so consistency isn't great.

I guess changing the protobuf package will have to happen before v5 xD

@AnomalRoil AnomalRoil merged commit 51fbdad into drandmerge Jun 12, 2024
24 checks passed
@AnomalRoil AnomalRoil deleted the protobuf-fix branch June 12, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fixed-length integers to improve cross-platform compatibility Building on 32-bit systems fail
2 participants