Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE2] #1749 Start connection upon start #1764

Merged
merged 2 commits into from
Mar 7, 2024
Merged

[BE2] #1749 Start connection upon start #1764

merged 2 commits into from
Mar 7, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

  • Added read instruction at the start of the FileMonitor which is created in response to ping at the start of connectionMediator

@DanielTavaresA DanielTavaresA requested a review from a team as a code owner February 28, 2024 13:20
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇		 6
▀▀▀		 5d 21h 36m
▀▀▀▀		 10
▀▀▀▀▀
MariemBaccari
🥈		 4
▀▀		 1d 17h 15m
▀		 1
▀
sgueissa
🥉		 2
▀		 4d 21h 25m
▀▀▀		 8
▀▀▀▀
jbsv
 2
▀		 1d 7h 33m
▀		 0
arnauds5
 1
▀		 6h 55m
 0
osm-alt
 1
▀		 5h 52m
 0
ljankoschek
 1
▀		 20h 9m
▀		 0
K1li4nL
 1
▀		 18m
 0
emonnin-epfl
 1
▀		 6h 45m
 1
▀

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@DanielTavaresA DanielTavaresA linked an issue Mar 6, 2024 that may be closed by this pull request
[BE2]: Kickstart peer-to-peer connection upon server start #1749
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

K1li4nL
K1li4nL approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@DanielTavaresA DanielTavaresA merged commit a05ef69 into master Mar 7, 2024
18 checks passed
@DanielTavaresA DanielTavaresA deleted the work-be2-DTavaresA-kickstart-connection-server-start branch March 7, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees
No one assigned
Labels
be2-scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE2]: Kickstart peer-to-peer connection upon server start
3 participants
@DanielTavaresA @CLAassistant @K1li4nL