-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE2] Add rumor state creation #1905
Conversation
Pull reviewers statsStats of the last 30 days for popstellar:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks good and well documented, just left some comments that could be addressed.
be2-scala/src/main/scala/ch/epfl/pop/decentralized/ConnectionMediator.scala
Show resolved
Hide resolved
be2-scala/src/main/scala/ch/epfl/pop/decentralized/ConnectionMediator.scala
Show resolved
Hide resolved
…iel-rumor-state-creation
🟠 There seems to be some formatting issues that must be applied from PR #1941 first. |
🟠 There seems to be some formatting issues that must be applied from PR #1941 first. |
…el-rumor-state-creation Fixes by auto-format action
Quality Gate passed for 'PoP - PoPCHA-Web-Client'Issues Measures |
Quality Gate passed for 'PoP - Be2-Scala'Issues Measures |
Quality Gate passed for 'PoP - Be1-Go'Issues Measures |
Quality Gate passed for 'PoP - Fe2-Android'Issues Measures |
Pending on #1900
Periodically, we create rumor state with the map of the last rumor id viewed for each public key known to the server