Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE2] Add rumor state creation #1905

Merged
merged 17 commits into from
Jun 24, 2024
Merged

Conversation

DanielTavaresA
Copy link
Collaborator

@DanielTavaresA DanielTavaresA commented Jun 3, 2024

Pending on #1900

Periodically, we create rumor state with the map of the last rumor id viewed for each public key known to the server

Copy link

github-actions bot commented Jun 3, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
12
▀▀▀
4d 19h 42m
14
▀▀▀
simone-kalbermatter
🥈
4
8h 40m
0
onsriahi14
🥉
4
1d 23h 8m
4
matteosz
4
4d 1h 8m
5
pierluca
2
3d 11h 3m
1
arnauds5
2
5d 15h 3m
▀▀
0
emonnin-epfl
2
3h 14m
2
DanielTavaresA
2
2d 10h 22m
8
▀▀
quadcopterman
2
6d 13h 46m
▀▀
1
Tyratox
1
44m
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

@DanielTavaresA DanielTavaresA changed the base branch from master to work-be2-daniel-rumor-state-answer-handler June 3, 2024 16:51
@DanielTavaresA DanielTavaresA changed the base branch from work-be2-daniel-rumor-state-answer-handler to master June 3, 2024 16:53
@DanielTavaresA DanielTavaresA changed the base branch from master to fix-be2-daniel-gossip-relay June 4, 2024 09:57
@DanielTavaresA DanielTavaresA changed the base branch from fix-be2-daniel-gossip-relay to master June 4, 2024 09:57
@DanielTavaresA DanielTavaresA changed the base branch from master to fix-be2-daniel-gossip-relay June 4, 2024 10:00
@DanielTavaresA DanielTavaresA changed the base branch from fix-be2-daniel-gossip-relay to master June 4, 2024 10:20
@DanielTavaresA DanielTavaresA changed the base branch from master to fix-be2-daniel-gossip-relay June 4, 2024 10:21
Base automatically changed from fix-be2-daniel-gossip-relay to master June 5, 2024 14:45
@DanielTavaresA DanielTavaresA marked this pull request as ready for review June 14, 2024 14:16
@DanielTavaresA DanielTavaresA requested a review from a team as a code owner June 14, 2024 14:16
Copy link
Contributor

@onsriahi14 onsriahi14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code looks good and well documented, just left some comments that could be addressed.

Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1941 first.

Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1941 first.

Copy link

sonarcloud bot commented Jun 20, 2024

Copy link

sonarcloud bot commented Jun 20, 2024

Copy link

sonarcloud bot commented Jun 20, 2024

Copy link

sonarcloud bot commented Jun 20, 2024

@K1li4nL K1li4nL added this pull request to the merge queue Jun 24, 2024
Merged via the queue into master with commit 5432866 Jun 24, 2024
17 checks passed
@K1li4nL K1li4nL deleted the work-be2-daniel-rumor-state-creation branch June 24, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants