New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete validation and tests for CreateRollCall data #1952

Merged

Kaz-ookid merged 4 commits into master from work-fe2-maxime-rollcall-data-validation

Jun 27, 2024

Contributor

Kaz-ookid commented Jun 27, 2024

addressing #1751 : Now complete validation for CreateRollCall data.


          complete validation and tests for CreateRollCall data

884e4af

Kaz-ookid requested a review from a team as a code owner

June 27, 2024 10:50

github-actions bot commented Jun 27, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	22 ▀▀▀▀	3d 30m ▀	14 ▀▀
	arnauds5 🥈	6 ▀	7h	4 ▀
	matteosz 🥉	6 ▀	3d 16h 27m ▀	19 ▀▀▀
	emonnin-epfl	5 ▀	8h 20m	8 ▀
	onsriahi14	3 ▀	1d 10h 51m	4 ▀
	1florentin	2	10d 5h 50m ▀▀▀	0
	sgueissa	2	12h 56m	5 ▀
	MariemBaccari	2	22h 39m	6 ▀
	simone-kalbermatter	2	5h 32m	0
	quadcopterman	2	10d 1h 21m ▀▀▀	0
^{⚡️ Pull request stats}

github-actions bot mentioned this pull request

Fixes by auto-format action #1953

Closed

github-actions bot commented Jun 27, 2024

🟠 There seems to be some formatting issues that must be applied from PR #1953 first.


          removed forgotten empty init{}

0bc97d3

github-actions bot commented Jun 27, 2024

🟠 There seems to be some formatting issues that must be applied from PR #1953 first.


          little refactor

8f36e23

github-actions bot commented Jun 27, 2024

🟠 There seems to be some formatting issues that must be applied from PR #1953 first.

1 similar comment

github-actions bot commented Jun 27, 2024

🟠 There seems to be some formatting issues that must be applied from PR #1953 first.

Kaz-ookid mentioned this pull request

Federation Data Exchange for FE2 #1943

Merged

matteosz added the fe2-android label

matteosz reviewed

View reviewed changes

Contributor

matteosz left a comment

Great! Will approve as soon as you manage to solve the CI failing for auto-format


          Merge remote-tracking branch 'refs/remotes/origin/master' into work-f…

18c9358

…e2-maxime-rollcall-data-validation

sonarcloud bot commented Jun 27, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 27, 2024

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 27, 2024

Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 27, 2024

Quality Gate passed for 'PoP - Fe2-Android'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
89.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

matteosz self-requested a review

June 27, 2024 13:17

matteosz approved these changes

View reviewed changes

Kaz-ookid added this pull request to the merge queue

Merged via the queue into master with commit e68e9ee

17 checks passed

Kaz-ookid deleted the work-fe2-maxime-rollcall-data-validation branch

June 27, 2024 14:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels