Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work be1 arnauds5 federation tokens exchange rumor #1975

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Work be1 arnauds5 federation tokens exchange rumor #1975

merged 3 commits into from
Jun 30, 2024

Conversation

arnauds5
Copy link
Collaborator

No description provided.

@arnauds5 arnauds5 requested a review from a team as a code owner June 30, 2024 16:53
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 27
▀▀▀▀		 12h 13m
 12
▀▀
matteosz
🥈		 12
▀▀		 2d 6m
 22
▀▀▀
arnauds5
🥉		 8
▀		 1h 57m
 4
▀
emonnin-epfl
 8
▀		 8h 20m
 8
▀
sgueissa
 5
▀		 1h 25m
 7
▀
MariemBaccari
 4
▀		 2h 2m
 6
▀
onsriahi14
 3
 1d 10h 51m
 4
▀
quadcopterman
 3
 10d 7h 3m
▀▀		 1
4xiom5
 2
 21d 11h 22m
▀▀▀▀		 0
1florentin
 2
 10d 5h 50m
▀▀		 0
Kaz-ookid
 2
 2d 4h 12m
 9
▀
simone-kalbermatter
 1
 9h 17m
 0
⚡️ Pull request stats

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 30, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 30, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 30, 2024

Quality Gate Failed Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
46.9% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 30, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arnauds5 arnauds5 requested a review from sgueissa June 30, 2024 17:40
sgueissa
sgueissa approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgueissa sgueissa enabled auto-merge June 30, 2024 17:43
K1li4nL
K1li4nL approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval

@sgueissa sgueissa added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 0f2cb4b Jun 30, 2024
16 of 17 checks passed
@sgueissa sgueissa deleted the work-be1-arnauds5-federation-tokens-exchange-rumor branch June 30, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgueissa sgueissa sgueissa approved these changes

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees
No one assigned
Labels
be1-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnauds5 @sgueissa @K1li4nL @matteosz