New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix key read and instant pull #1977

Merged

sgueissa merged 2 commits into master from fix-be2-daniel-readpk

Jun 30, 2024

Collaborator

DanielTavaresA commented Jun 30, 2024

Fixed bug killing GossipManager when readkey times out and shares instantly pull upon new connection


          fix key read and instant pull

7f2634c

DanielTavaresA requested a review from a team as a code owner

June 30, 2024 20:20

github-actions bot commented Jun 30, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	30 ▀▀▀▀	7h 1m	12 ▀▀
	matteosz 🥈	12 ▀	2d 6m	22 ▀▀▀
	arnauds5 🥉	9 ▀	1h 10m	4 ▀
	sgueissa	8 ▀	1h 13m	7 ▀
	emonnin-epfl	8 ▀	8h 20m	8 ▀
	MariemBaccari	4	2h 2m	6 ▀
	onsriahi14	3	1d 10h 51m	4 ▀
	quadcopterman	3	10d 7h 3m ▀▀	1
	4xiom5	2	21d 11h 22m ▀▀▀▀	0
	1florentin	2	10d 5h 50m ▀▀	0
	Kaz-ookid	2	2d 4h 12m	9 ▀
	simone-kalbermatter	1	9h 17m	0
^{⚡️ Pull request stats}

K1li4nL added the be2-scala label

sgueissa enabled auto-merge

June 30, 2024 20:21


          fix tests

bc3bc79

sonarcloud bot commented Jun 30, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 30, 2024

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 30, 2024

Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

K1li4nL approved these changes

View reviewed changes

sonarcloud bot commented Jun 30, 2024

Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sgueissa added this pull request to the merge queue

Merged via the queue into master with commit a2b1d53

17 checks passed

sgueissa deleted the fix-be2-daniel-readpk branch

June 30, 2024 20:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels