Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add asv benchmark jobs to CI #234

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

Illviljan
Copy link

@Illviljan Illviljan commented Jan 25, 2022

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #234 (324c802) into master (42b1bc3) will not change coverage.
The diff coverage is n/a.

❗ Current head 324c802 differs from pull request most recent head dcdd3a3. Consider uploading reports for the commit dcdd3a3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          40       40           
  Lines         978      978           
=======================================
  Hits          966      966           
  Misses         12       12           
Flag Coverage Δ
unittests 98.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b1bc3...dcdd3a3. Read the comment docs.

@Illviljan Illviljan changed the title Add asv benchmark ci test: Add asv benchmark ci Jan 25, 2022
Comment on lines +60 to +66
"matrix": {
"setuptools": [""],
"setuptools_scm[toml]": [""],
"Cython": [""],
"numpy": [""],
"scipy": [""],
},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the required installs needs to be here as well.

@Illviljan Illviljan marked this pull request as ready for review January 28, 2022 21:16
@Illviljan
Copy link
Author

Ok this is ready for review now, it passes on my local fork at least Illviljan#1.
If you add the label run-benchmark the benchmark will run.

The benchmarks probably needs a bit more thought by someone more experienced. But that's for another PR I think.

@Illviljan Illviljan changed the title test: Add asv benchmark ci test: Add asv benchmark jobs to CI Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add airspeed velocity benchmarks
2 participants