Made the versions easier to update.

deephaven-examples · Apr 30, 2024 · ba169a3 · ba169a3
1 parent f906127
commit ba169a3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/build-and-publish.yml b/.github/workflows/build-and-publish.yml
@@ -22,17 +22,11 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v1
-    # TODO: remove
-    - name: DEBUG
-      run: pwd
     - name: Build
       run: |
         cd ibwhl
         docker-compose -f "docker-compose.yml" up --build
         find . -name \*.whl
-    # TODO: remove
-    - name: DEBUG
-      run: pwd && find . -name \*.whl
     - name: Archive build artifacts
       uses: actions/upload-artifact@v2
       with:

diff --git a/dhib_env.py b/dhib_env.py
@@ -13,6 +13,9 @@
 import pkginfo
 import requests
 
+IB_VERSION_DEFAULT="10.19.04"
+DH_VERSION_DEFAULT="0.33.3"
+
 ########################################################################################################################
 # Shell
 ########################################################################################################################
@@ -265,8 +268,8 @@ def cli():
 
 @click.command()
 @click.option('--python', default="python3", help='The path to the Python executable to use.')
-@click.option('--dh_version', default="0.33.3", help='The version of Deephaven.')
-@click.option('--ib_version', default="10.19.04", help='The version of ibapi.')
+@click.option('--dh_version', default=DH_VERSION_DEFAULT, help='The version of Deephaven.')
+@click.option('--ib_version', default=IB_VERSION_DEFAULT, help='The version of ibapi.')
 @click.option('--dh_ib_version', default=None, help='The version of deephaven-ib.')
 @click.option('--delete_venv', default=False, help='Whether to delete the virtual environment if it already exists.')
 def dev(python: str, dh_version: str, ib_version: str, dh_ib_version: Optional[str], delete_venv: bool):