-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoongArch: add old BPI compatibility #127
LoongArch: add old BPI compatibility #127
Conversation
Hi @sterling-teng. Thanks for your PR. 😃 |
Hi @sterling-teng. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8974e6e
to
152de5e
Compare
/ok-to-test |
arch/loongarch/kernel/Makefile
Outdated
@@ -9,6 +9,7 @@ obj-y += head.o cpu-probe.o cacheinfo.o env.o setup.o entry.o genex.o \ | |||
traps.o irq.o idle.o process.o dma.o mem.o io.o reset.o switch.o \ | |||
elf.o syscall.o signal.o time.o topology.o inst.o ptrace.o vdso.o \ | |||
alternative.o unwind.o | |||
obj-y += legacy_boot.o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请调整空格以对齐缩进。
Please adjust the indent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
arch/loongarch/kernel/legacy_boot.h
Outdated
#define LOONGSON_MEM_SIGNATURE "MEM" | ||
#define LOONGSON_VBIOS_SIGNATURE "VBIOS" | ||
#define LOONGSON_EFIBOOT_SIGNATURE "BPI" | ||
#define LOONGSON_SCREENINFO_SIGNATURE "SINFO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请调整缩进。
Please adjust the indent.
drivers/firmware/efi/Makefile
Outdated
@@ -37,6 +37,7 @@ obj-$(CONFIG_ARM) += $(arm-obj-y) | |||
obj-$(CONFIG_ARM64) += $(arm-obj-y) | |||
riscv-obj-$(CONFIG_EFI) := efi-init.o riscv-runtime.o | |||
obj-$(CONFIG_RISCV) += $(riscv-obj-y) | |||
#obj-$(CONFIG_LOONGARCH) += efi-init.o | |||
obj-$(CONFIG_EFI_CAPSULE_LOADER) += capsule-loader.o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么要在这里添加一行注释?
Why add a comment here?
arch/loongarch/Kconfig
Outdated
@@ -144,6 +144,7 @@ config LOONGARCH | |||
select HAVE_SAMPLE_FTRACE_DIRECT_MULTI | |||
select HAVE_SETUP_PER_CPU_AREA if NUMA | |||
select HAVE_STACKPROTECTOR | |||
select ARCH_HAS_PHYS_TO_DMA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否应该调整位置?
Would u like to adjust the position?
3cb02c3
to
67d1779
Compare
152de5e
to
67d1779
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review代码审查报告 代码路径:/Users/username/project/python/code.py
import os
import pathlib
from typing import IO
def open_file(file_path: str, mode: str = "r") -> IO:
"""打开文件,返回文件对象"""
file_path = os.path.abspath(os.path.join(os.path.curdir, file_path))
try:
with open(file_path, mode) as file:
return file
except FileNotFoundError:
print(f"文件未找到: {file_path}")
raise
except IOError as e:
print(f"文件读取错误: {file_path}\n错误信息: {e}")
raise
# 使用示例
file_path = "path/to/your/file.txt"
with open_file(file_path) as file:
content = file.read()
print(content)
|
This is a general PR, mainly adding compatibility support for ABI1.0 and ABI2.0, and some fixes. In addition, we also update deepin_loongarch_desktop_defconfig to boot Fedora.
Some links:
Fedora ISO: https://github.com/fedora-remix-loongarch/releases-info
Diff of ABI1.0 and ABI2.0: loongson/LoongArch-Documentation#74
Firmware: https://github.com/loongson/Firmware/tree/main
Yanteng Si (6):
LoongArch: add kernel setvirtmap for runtime
LoongArch: Old BPI compatibility
LoongArch: Fix virtual machine startup error
LoongArch: Fixed EIOINTC structure members
LoongArch: use arch specific phys_to_dma
LoongArch: Update deepin_loongarch_desktop_defconfig