[Deepin-Kernel-SIG] [Upstream] [linux 6.6-y] Sync some mac80211 bugfix from mainline v6.7

[opsiff]

Fix patches in #69
Commit(11):
wifi: mac80211: add/remove driver debugfs entries as appropriate
wifi: mac80211: do not re-add debugfs entries during resume
wifi: mac80211: drop robust action frames before assoc
wifi: mac80211: purge TX queues in flush_queues flow
wifi: mac80211: fix a expired vs. cancel race in roc
wifi: mac80211: mesh: fix some kdoc warnings
wifi: cfg80211: Include operating class 137 in 6GHz band
wifi: mac80211: handle debugfs when switching to/from MLO
wifi: mac80211: cleanup auth_data only if association continues
wifi: mac80211: split ieee80211_drop_unencrypted_mgmt() return value
wifi: mac80211: remove RX_DROP_UNUSABLE

Summary by Sourcery

This pull request synchronizes several bug fixes and enhancements from the mainline kernel v6.7 into the Deepin Kernel, primarily focusing on mac80211 improvements. These include fixes for race conditions, debugfs handling, and memory management, as well as enhancements to mesh networking and support for the 6GHz band.

Bug Fixes:

• Fixes a race condition in ROC (Remain On Channel) cancellation to ensure proper handling of hardware notifications.
• Fixes an issue where debugfs entries were being re-added during resume.
• Fixes a bug where authentication data was not being properly cleaned up after association attempts.
• Fixes a bug where TX queues were not being purged in flush_queues flow.

Enhancements:

• Improves debugfs handling for MLO (Multi-Link Operation) by adding and removing driver debugfs entries as appropriate when switching to/from MLO.
• Adds a function to purge all TX queues for a given station.
• Adds operating class 137 to the 6GHz band.

Chores:

• Drops robust action frames before association, regardless of MFP state.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request synchronizes several bug fixes from the mainline v6.7 kernel into the Deepin Kernel SIG's linux 6.6-y branch. The changes address issues in mac80211, including debugfs handling, mesh path management, ROC cancellation, MFP, and queue flushing. It also adds support for operating class 137 in the 6GHz band.

Sequence diagram for ROC cancellation

sequenceDiagram
    participant User Space
    participant mac80211
    participant Driver

    User Space->>mac80211: Cancel ROC
    mac80211->>Driver: drv_cancel_remain_on_channel
    Driver-->>mac80211: Returns from drv_cancel_remain_on_channel
    mac80211->>mac80211: wiphy_work_cancel(hw_roc_done)
    Note over mac80211: Cancel the work to ensure all pending workers have completed execution

Loading

Sequence diagram for association management

sequenceDiagram
    participant ieee80211_mgd_assoc
    participant ieee80211_destroy_auth_data

    ieee80211_mgd_assoc->>ieee80211_destroy_auth_data: destroy auth_data if association continues
    Note over ieee80211_mgd_assoc,ieee80211_destroy_auth_data: Cleanup is delayed if auth_data matches
    ieee80211_mgd_assoc->>ieee80211_destroy_auth_data: destroy auth_data after association

Loading

Updated class diagram for ieee80211_sub_if_data

classDiagram
    class ieee80211_sub_if_data {
        +debugfs_dir
        +deflink
        +flags
        +vif
    }

    class ieee80211_link_data {
        +debugfs_dir
    }

    ieee80211_sub_if_data -- ieee80211_link_data: has a
    note for ieee80211_sub_if_data "The debugfs_dir is now also assigned to deflink."

Loading

File-Level Changes

Change	Details	Files
Introduces a function to purge all TX queues associated with a station (sta_info) and uses it in the station cleanup process.	Introduces ieee80211_purge_sta_txqs to purge all TX queues of a station. Calls ieee80211_purge_sta_txqs in __cleanup_single_sta to ensure TX queues are purged during station cleanup.	net/mac80211/sta_info.c
Enhances debugfs handling for network devices, especially in MLO (Multi-Link Operation) scenarios, by adding, removing, and recreating debugfs entries as needed.	Modifies ieee80211_debugfs_add_netdev to accept a boolean mld_vif to indicate if it is a MLO VIF. Creates ieee80211_debugfs_recreate_netdev to remove and re-add debugfs entries, used when switching to/from MLO. Updates drv_remove_interface to use ieee80211_debugfs_recreate_netdev to handle debugfs removal during interface removal. Modifies drv_add_interface to add debugfs entries only if the IEEE80211_SDATA_IN_DRIVER flag is not set. Updates drv_change_vif_links to avoid adding debugfs entries during reconfig or resume. Updates drv_change_sta_links to avoid adding debugfs entries during reconfig or resume.	net/mac80211/debugfs_netdev.c net/mac80211/driver-ops.c net/mac80211/debugfs_netdev.h
Fixes and improves documentation for mesh path management functions.	Adds KDoc documentation to mesh_path_move_to_queue. Adds return value documentation to mesh_path_add_gate and mesh_path_send_to_gates. Adds return value documentation to mesh_gate_num.	net/mac80211/mesh_pathtbl.c
Fixes a race condition in ROC (Remain-on-Channel) cancellation and ensures proper cleanup of authentication data during association.	Adds wiphy_work_cancel to ieee80211_cancel_roc to prevent race conditions during ROC cancellation. Modifies ieee80211_mgd_assoc to delay cleanup of authentication data if it matches the association request and to ensure cleanup during association.	net/mac80211/offchannel.c net/mac80211/mlme.c
Drops robust action frames before association, regardless of MFP (Management Frame Protection) state.	Modifies ieee80211_drop_unencrypted_mgmt to drop robust action frames before association.	net/mac80211/rx.c
Adds operating class 137 to the 6GHz band.	Adds case 137 to ieee80211_operating_class_to_band to map it to the 6GHz band.	net/wireless/util.c
Purges TX queues when flushing queues to prevent frames from being sent during queue wake-up.	Adds a call to ieee80211_purge_sta_txqs in __ieee80211_flush_queues to purge TX queues when flushing.	net/mac80211/util.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

• The debugfs changes look good, but it might be worth double-checking how they interact with the driver's debugfs implementation.
• The commit message for 'wifi: mac80211: purge TX queues in flush_queues flow' could be more descriptive about why this change is needed.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (complexity): Consider using early returns/guard clauses to reduce nesting and improve readability in functions like ieee80211_debugfs_recreate_netdev and ieee80211_link_debugfs_add.

In functions like `ieee80211_debugfs_recreate_netdev` and `ieee80211_link_debugfs_add`, consider using early returns/guard clauses to avoid extra nesting. For example, you may refactor the nested if–statements in `ieee80211_debugfs_recreate_netdev` as follows:

--- Before ---
```c
ieee80211_debugfs_remove_netdev(sdata);
ieee80211_debugfs_add_netdev(sdata, mld_vif);

if (sdata->flags & IEEE80211_SDATA_IN_DRIVER) {
    drv_vif_add_debugfs(sdata->local, sdata);
    if (!mld_vif)
        ieee80211_link_debugfs_drv_add(&sdata->deflink);
}

--- After ---

ieee80211_debugfs_remove_netdev(sdata);
ieee80211_debugfs_add_netdev(sdata, mld_vif);

if (!(sdata->flags & IEEE80211_SDATA_IN_DRIVER))
    return;

drv_vif_add_debugfs(sdata->local, sdata);
if (mld_vif)
    return;

ieee80211_link_debugfs_drv_add(&sdata->deflink);

Similarly, in ieee80211_link_debugfs_add, instead of combining multiple WARN_ON checks in one compound condition, separate them:

--- Before ---

if (WARN_ON(!link->sdata->vif.debugfs_dir || link->debugfs_dir))
    return;
if (WARN_ON(!(link->sdata->local->hw.wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO)))
    return;

--- After ---

if (!link->sdata->vif.debugfs_dir) {
    WARN_ON(true);
    return;
}
if (link->debugfs_dir) {
    WARN_ON(true);
    return;
}
if (!(link->sdata->local->hw.wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO)) {
    WARN_ON(true);
    return;
}

These small changes improve readability by reducing nested branches while keeping the functionality intact.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment