Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin: wifi: mt76: mt7921: add pci aspm probe log #616

Merged

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Feb 21, 2025

We met many platform relate issue, add the log to help tracking aspm bug.

Summary by Sourcery

Enhancements:

  • Added logging to the mt7921 PCI probe function to aid in debugging ASPM-related issues.

We met many platform relate issue,
add the log to help tracking aspm bug.

Signed-off-by: Wentao Guan <[email protected]>
Copy link

sourcery-ai bot commented Feb 21, 2025

Reviewer's Guide by Sourcery

This pull request adds a log message in the mt7921_pci_probe function to print the values of mt7921_disable_aspm and dev->aspm_supported. This change aims to aid in tracking down ASPM-related issues on different platforms by providing more visibility into the state of ASPM during the device initialization.

Sequence diagram for mt7921_pci_probe with added logging

sequenceDiagram
  participant pci_dev
  participant mt7921_pci_probe
  participant mt76_pci_aspm_supported
  participant mt792xe_mcu_fw_pmctrl
  participant pr_info

  pci_dev->>mt7921_pci_probe: pci_dev
  mt7921_pci_probe->>mt76_pci_aspm_supported: mt76_pci_aspm_supported(pdev)
  alt mt7921_disable_aspm is false and ASPM is supported
    mt7921_pci_probe->>mt7921_pci_probe: dev->aspm_supported = true
  end
  mt7921_pci_probe->>pr_info: pr_info("mt7921_pci_probe: disable_aspm:%d,aspm_supported:%d", mt7921_disable_aspm, dev->aspm_supported)
  mt7921_pci_probe->>mt792xe_mcu_fw_pmctrl: mt792xe_mcu_fw_pmctrl(dev)
  mt792xe_mcu_fw_pmctrl-->>mt7921_pci_probe: ret
  alt ret != 0
    mt7921_pci_probe->>mt7921_pci_probe: goto err_free_dev
  end
  mt7921_pci_probe-->>pci_dev: ret
Loading

File-Level Changes

Change Details Files
Added a log message to print the values of mt7921_disable_aspm and dev->aspm_supported during the mt7921_pci_probe function.
  • Added a pr_info statement to log the values of mt7921_disable_aspm and dev->aspm_supported.
drivers/net/wireless/mediatek/mt76/mt7921/pci.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using dynamic debug instead of pr_info to avoid spamming the logs in normal operation.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit 1d77ae9 into deepin-community:linux-6.6.y Feb 21, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants