-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepin: wifi: mt76: mt7921: add pci aspm probe log #616
deepin: wifi: mt76: mt7921: add pci aspm probe log #616
Conversation
We met many platform relate issue, add the log to help tracking aspm bug. Signed-off-by: Wentao Guan <[email protected]>
Reviewer's Guide by SourceryThis pull request adds a log message in the Sequence diagram for mt7921_pci_probe with added loggingsequenceDiagram
participant pci_dev
participant mt7921_pci_probe
participant mt76_pci_aspm_supported
participant mt792xe_mcu_fw_pmctrl
participant pr_info
pci_dev->>mt7921_pci_probe: pci_dev
mt7921_pci_probe->>mt76_pci_aspm_supported: mt76_pci_aspm_supported(pdev)
alt mt7921_disable_aspm is false and ASPM is supported
mt7921_pci_probe->>mt7921_pci_probe: dev->aspm_supported = true
end
mt7921_pci_probe->>pr_info: pr_info("mt7921_pci_probe: disable_aspm:%d,aspm_supported:%d", mt7921_disable_aspm, dev->aspm_supported)
mt7921_pci_probe->>mt792xe_mcu_fw_pmctrl: mt792xe_mcu_fw_pmctrl(dev)
mt792xe_mcu_fw_pmctrl-->>mt7921_pci_probe: ret
alt ret != 0
mt7921_pci_probe->>mt7921_pci_probe: goto err_free_dev
end
mt7921_pci_probe-->>pci_dev: ret
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @opsiff - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using dynamic debug instead of
pr_info
to avoid spamming the logs in normal operation.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sourcery-ai[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We met many platform relate issue, add the log to help tracking aspm bug.
Summary by Sourcery
Enhancements: