-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] pci/quirks: LS7A2000: Fix quirks runs on every platform #619
[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] pci/quirks: LS7A2000: Fix quirks runs on every platform #619
Conversation
The quirk function be complied and run everywhere machine. I saw it that in my daliy test kernel initcall_debug log. As Kconfig MACH_LOONGSON64 say, limit quirks it by this config. Fixes: 8f6b968 ("pci/quirks: LS7A2000: Fix pm transition of devices under pcie port") Signed-off-by: Wentao Guan <[email protected]>
Reviewer's Guide by SourceryThis pull request addresses an issue where the LS7A2000 PCIe port quirks were being applied on all platforms, leading to unnecessary execution of the quirk function. The fix limits the execution of these quirks to only Loongson64 architecture-based machines by wrapping the relevant code in a conditional compilation block. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @opsiff - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
IS_ENABLED(CONFIG_MACH_LOONGSON64)
instead of#if defined(CONFIG_MACH_LOONGSON64)
to allow for tristate configs.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sourcery-ai[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
需要咨询一下陈大师,有无较好的方式推动其upstream |
/lgtm |
The quirk function be complied and run everywhere machine.
I saw it that in my daliy test kernel initcall_debug log.
As Kconfig MACH_LOONGSON64 say, limit quirks it by this config.
Fixes: 8f6b968 ("pci/quirks: LS7A2000: Fix pm transition of devices under pcie port")
Log:
[ 0.000000] microcode: updated early: 0x4111 -> 0x4123, date = 2024-05-29
[ 0.000000] Linux version 6.6.78-g9460afe3d9ac (deepin@deepin-PC) (gcc (Deepin 12.3.0-17deepin8) 12.3.0, GNU ld (GNU Binutils for Deepin) 2.41) (9460afe3d) #4 SMP PREEMPT_DYNAMIC Sat Feb 22 17:18:35 CST 2025
........
[ 1.147608] pci 0000:00:0d.0: calling loongson_d3_and_link_quirk+0x0/0x80 @ 1
........
[ 1.164242] pcieport 0000:00:06.0: calling loongson_d3_and_link_quirk+0x0/0x80 @ 1
........
[ 1.341470] nvme 0000:02:00.0: calling loongson_d3_and_link_quirk+0x0/0x80 @ 160
........
[ 21.330986] xhci_hcd 0000:00:0d.0: loongson_d3_and_link_quirk+0x0/0x80 took 0 usecs
Summary by Sourcery
Bug Fixes: