Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] pci/quirks: LS7A2000: Fix quirks runs on every platform #619

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Feb 23, 2025

The quirk function be complied and run everywhere machine.
I saw it that in my daliy test kernel initcall_debug log.
As Kconfig MACH_LOONGSON64 say, limit quirks it by this config.

Fixes: 8f6b968 ("pci/quirks: LS7A2000: Fix pm transition of devices under pcie port")

Log:
[ 0.000000] microcode: updated early: 0x4111 -> 0x4123, date = 2024-05-29
[ 0.000000] Linux version 6.6.78-g9460afe3d9ac (deepin@deepin-PC) (gcc (Deepin 12.3.0-17deepin8) 12.3.0, GNU ld (GNU Binutils for Deepin) 2.41) (9460afe3d) #4 SMP PREEMPT_DYNAMIC Sat Feb 22 17:18:35 CST 2025
........
[ 1.147608] pci 0000:00:0d.0: calling loongson_d3_and_link_quirk+0x0/0x80 @ 1
........
[ 1.164242] pcieport 0000:00:06.0: calling loongson_d3_and_link_quirk+0x0/0x80 @ 1
........
[ 1.341470] nvme 0000:02:00.0: calling loongson_d3_and_link_quirk+0x0/0x80 @ 160
........
[ 21.330986] xhci_hcd 0000:00:0d.0: loongson_d3_and_link_quirk+0x0/0x80 took 0 usecs

Summary by Sourcery

Bug Fixes:

  • Fixes a bug where the LS7A2000 PCIe port quirks were being applied on non-Loongson64 architectures, by limiting the quirks to the Loongson64 architecture.

The quirk function be complied and run everywhere machine.
I saw it that in my daliy test kernel initcall_debug log.
As Kconfig MACH_LOONGSON64 say, limit quirks it by this config.

Fixes: 8f6b968 ("pci/quirks: LS7A2000: Fix pm transition of devices under pcie port")
Signed-off-by: Wentao Guan <[email protected]>
Copy link

sourcery-ai bot commented Feb 23, 2025

Reviewer's Guide by Sourcery

This pull request addresses an issue where the LS7A2000 PCIe port quirks were being applied on all platforms, leading to unnecessary execution of the quirk function. The fix limits the execution of these quirks to only Loongson64 architecture-based machines by wrapping the relevant code in a conditional compilation block.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The patch limits the execution of the LS7A2000 PCIe port quirks to Loongson64 architecture-based machines.
  • Wrapped the Loongson-specific PCIe port quirk code in a #ifdef CONFIG_MACH_LOONGSON64 block.
  • Added #endif to close the conditional compilation block.
drivers/pci/quirks.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using IS_ENABLED(CONFIG_MACH_LOONGSON64) instead of #if defined(CONFIG_MACH_LOONGSON64) to allow for tristate configs.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714
Copy link
Collaborator

需要咨询一下陈大师,有无较好的方式推动其upstream

@Avenger-285714
Copy link
Collaborator

/lgtm

@opsiff opsiff merged commit 2f9a670 into deepin-community:linux-6.6.y Feb 24, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants