Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate with gh #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: integrate with gh #17

wants to merge 4 commits into from

Conversation

ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented Oct 25, 2024

  • add an action to publish the package on tag creation
  • enables customers to use gh versioning & auto pushing to dC

@@ -0,0 +1,41 @@
name: Build and Push Custom Component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Let's also add a testing step in the CI + documentation (e.g. how to trigger, where to put API key etc.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArzelaAscoIi How about also adding a flow on: pullrequest which runs the linting + testing steps?

@ArzelaAscoIi
Copy link
Member Author

Copy link
Collaborator

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke about this with Jul's yesterday @ArzelaAscoIi . It makes a lot of sense from our developer perspective but not so much from Sol / Customer perspective - I linked more information on the Jira item: https://deepset.atlassian.net/browse/DCD-468

We can still merge though - I just doubt it will see much use. Let's have Aga have a look over the docs first though.

@@ -96,3 +96,15 @@ It's crucial to thoroughly test your custom component before uploading it to dee
This creates a zip file called `custom_component.zip` in the `dist` directory and uploads it to deepset Cloud.

For detailed instructions, refer to our documentation on [Creating a Custom Component](https://docs.cloud.deepset.ai/docs/create-a-custom-component).

### GitHub Actions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agnieszka-m can you please help us out here to make the instructions for the user clearer?

@@ -0,0 +1,41 @@
name: Build and Push Custom Component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArzelaAscoIi How about also adding a flow on: pullrequest which runs the linting + testing steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants