feat: integrate with gh #17
Conversation
ArzelaAscoIi
commented
Oct 25, 2024
•
ArzelaAscoIi
commented
- add an action to publish the package on tag creation
- enables customers to use gh versioning & auto pushing to dC
| @@ -0,0 +1,41 @@ | |||
| name: Build and Push Custom Component | |||
There was a problem hiding this comment.
🔥 Let's also add a testing step in the CI + documentation (e.g. how to trigger, where to put API key etc.)
There was a problem hiding this comment.
@ArzelaAscoIi How about also adding a flow on: pullrequest which runs the linting + testing steps?
There was a problem hiding this comment.
Spoke about this with Jul's yesterday @ArzelaAscoIi . It makes a lot of sense from our developer perspective but not so much from Sol / Customer perspective - I linked more information on the Jira item: https://deepset.atlassian.net/browse/DCD-468
We can still merge though - I just doubt it will see much use. Let's have Aga have a look over the docs first though.
| @@ -96,3 +96,15 @@ It's crucial to thoroughly test your custom component before uploading it to dee | |||
| This creates a zip file called `custom_component.zip` in the `dist` directory and uploads it to deepset Cloud. | |||
|
|
|||
| For detailed instructions, refer to our documentation on [Creating a Custom Component](https://docs.cloud.deepset.ai/docs/create-a-custom-component). | |||
|
|
|||
| ### GitHub Actions | |||
There was a problem hiding this comment.
@agnieszka-m can you please help us out here to make the instructions for the user clearer?
| @@ -0,0 +1,41 @@ | |||
| name: Build and Push Custom Component | |||
There was a problem hiding this comment.
@ArzelaAscoIi How about also adding a flow on: pullrequest which runs the linting + testing steps?
