Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dynamically add workspaces in action #129

Merged
merged 16 commits into from
Nov 7, 2023
Merged

feat: dynamically add workspaces in action #129

merged 16 commits into from
Nov 7, 2023

Conversation

ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented Nov 6, 2023 •
edited
Loading

Related Issues

  • no

Proposed Changes?

  • run tests on new workspace

How did you test it?

  • running the CI

Notes for the reviewer

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@ArzelaAscoIi ArzelaAscoIi changed the title feat: dynamic workspace names feat: dynamically add workspaces in action Nov 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Coverage report

The coverage rate went from 92.9% to 92.9% ⬆️
The branch rate is 80%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

wochinge
wochinge approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 1d82a65 Nov 7, 2023
9 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the feat/dynamicWorkspace branch November 7, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArzelaAscoIi @wochinge