-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload less than 20 files via sync endpoints #142
Conversation
a90865f
to
3f9353e
Compare
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)deepset_cloud_sdk/_service/files_service.py
deepset_cloud_sdk/_api/files.py
|
7fe99b9
to
1471838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor points, but really great PR, and I can see there was a lot of effort on the testing!
I was actually also thinking about using the strategy pattern here: https://refactoring.guru/design-patterns/strategy/python/example. With that it would be possible to have two strategies (sync and batch) that are generated based on the number of files. Buuut i think its not for the effort for now 🙈 let's keep it in mind! Is that fine for you ? |
Related Issues
Proposed Changes?
How did you test it?
Checklist