Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow more file types [DC-1134] #171

Merged
merged 18 commits into from
Apr 26, 2024
Merged

Conversation

faymarie
Copy link
Contributor

@faymarie faymarie commented Apr 3, 2024

Related Issues

Allow uploading additional file types using SDK.
New file types: csv, docx, html, md, json, xml, xlsx,

https://deepset.atlassian.net/jira/software/c/projects/DC/boards/3?quickFilter=20&quickFilter=32&selectedIssue=DC-1134

  • fixes #DC-1134

Proposed Changes?

How did you test it?

Notes for the reviewer

Screenshots (optional)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

Copy link

swarmia bot commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  deepset_cloud_sdk
  cli.py
  deepset_cloud_sdk/_service
  files_service.py
  deepset_cloud_sdk/workflows/async_client
  files.py
  deepset_cloud_sdk/workflows/sync_client
  files.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already! Let's try this against ephemeral envs once the BE is ready. Will approve once the integration tests work 🙌

deepset_cloud_sdk/README.md Show resolved Hide resolved
deepset_cloud_sdk/_service/files_service.py Show resolved Hide resolved
docs/upload_files.md Show resolved Hide resolved
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice already! Just added a comment about the typing for the sync api

deepset_cloud_sdk/workflows/sync_client/files.py Outdated Show resolved Hide resolved
docs/upload_files.md Show resolved Hide resolved
@faymarie faymarie marked this pull request as ready for review April 26, 2024 10:20
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thank you!

@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue Apr 26, 2024
@@ -48,7 +48,7 @@ Replace <command> with one of the supported commands. To list all available comm

You don't have to follow any special folder structure. If there are multiple files with the same name in your folder, they're all uploaded by default. You can change this behavior with the `--write-mode` flag. See the examples below.

This command uploads the file example.txt to your deepset Cloud workspace.
This command uploads the file example.txt to your deepset Cloud workspace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @agnieszka-m this needs to be copied/documented again in readme now i think

Merged via the queue into main with commit 4b993db Apr 26, 2024
9 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the feat/allow-file-types-in-sdk branch April 26, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants