-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow more file types [DC-1134] #171
Conversation
✅ Linked to DC-1134 · Allow SDK to send new file types |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already! Let's try this against ephemeral envs once the BE is ready. Will approve once the integration tests work 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super nice already! Just added a comment about the typing for the sync api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Thank you!
@@ -48,7 +48,7 @@ Replace <command> with one of the supported commands. To list all available comm | |||
|
|||
You don't have to follow any special folder structure. If there are multiple files with the same name in your folder, they're all uploaded by default. You can change this behavior with the `--write-mode` flag. See the examples below. | |||
|
|||
This command uploads the file example.txt to your deepset Cloud workspace. | |||
This command uploads the file example.txt to your deepset Cloud workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @agnieszka-m this needs to be copied/documented again in readme now i think
Related Issues
Allow uploading additional file types using SDK.
New file types: csv, docx, html, md, json, xml, xlsx,
https://deepset.atlassian.net/jira/software/c/projects/DC/boards/3?quickFilter=20&quickFilter=32&selectedIssue=DC-1134
Proposed Changes?
How did you test it?
Notes for the reviewer
Screenshots (optional)
Checklist