Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower file type comparison #185

Merged
merged 10 commits into from
May 3, 2024
Merged

fix: lower file type comparison #185

merged 10 commits into from
May 3, 2024

Conversation

ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented Apr 30, 2024

Related Issues

Proposed Changes?

  • dont run lowercase comparison for metadata matching

How did you test it?

  • integration tests

Notes for the reviewer

  • we will skip files with capital suffixes as file types from now on

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  deepset_cloud_sdk/_service
  files_service.py
Project Total  

This report was generated by python-coverage-comment-action

@ArzelaAscoIi ArzelaAscoIi requested a review from faymarie May 3, 2024 08:47
@ArzelaAscoIi ArzelaAscoIi requested a review from wochinge May 3, 2024 08:52
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where exactly did it fail previously? Cause I think in general the lowercase comparisons are a neat idea

deepset_cloud_sdk/_service/files_service.py Show resolved Hide resolved
@ArzelaAscoIi ArzelaAscoIi requested a review from wochinge May 3, 2024 09:39
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll with that. I checked prod and nobody uploads .TXT files / similar.

@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 0f55cbf May 3, 2024
9 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the fix/lowerComp branch May 3, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case Sensitivity Issue in Filename Validation During Uploads
3 participants