Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error message for failed upload #99

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented Sep 4, 2023

Related Issues

  • hotfix

Proposed Changes?

  • add exception to logger
  • added exception to upload summary

How did you test it?

  • adjusted test

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Coverage report

The coverage rate went from 92.92% to 92.92% ➡️
The branch rate is 79%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

deepset_cloud_sdk/_s3/upload.py

100% of new lines are covered (91.02% of the complete file).

@ArzelaAscoIi ArzelaAscoIi merged commit 7b947ec into main Sep 4, 2023
9 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the feat/errorMessageForFailedUpload branch September 4, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants