Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with Python 3.9 #127

Merged
merged 3 commits into from
Oct 29, 2024
Merged

ci: test with Python 3.9 #127

merged 3 commits into from
Oct 29, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • use Python 3.9 in CI

How did you test it?

CI

Checklist

@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11571361461

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.515%

Totals Coverage Status
Change from base Build 11500246652: 0.0%
Covered Lines: 1716
Relevant Lines: 1917

💛 - Coveralls

@@ -20,13 +20,13 @@ on:
- synchronize
- ready_for_review
paths:
# Keep the list in sync with the paths defined in the `tests_skipper.yml` workflow
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests_skipper.yml does not exist in this repository

- "haystack_experimental/**/*.py"
- "test/**/*.py"
- "pyproject.toml"
- ".github/workflows/tests.yml"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change this workflow, we probably want to see if tests work

@anakin87 anakin87 marked this pull request as ready for review October 29, 2024 09:52
@anakin87 anakin87 requested a review from a team as a code owner October 29, 2024 09:52
@anakin87 anakin87 requested review from silvanocerza and removed request for a team October 29, 2024 09:52
@anakin87 anakin87 merged commit fbeeac7 into main Oct 29, 2024
15 checks passed
@anakin87 anakin87 deleted the py39 branch October 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants