revert: decrement 1 in bounded inputs instead of restrict fuzzing range

defi-wonderland · Nov 18, 2024 · 588b6bd · 588b6bd
1 parent 8b25aaa
commit 588b6bd
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/test/unit/HorizonAccountingExtension.t.sol b/test/unit/HorizonAccountingExtension.t.sol
@@ -826,16 +826,14 @@ contract HorizonAccountingExtension_Unit_ClaimEscalationReward is HorizonAccount
     uint256 _bondSize,
     uint256 _amount
   ) public {
-    vm.assume(_amount >= _bondSize);
-
     vm.assume(_pledger != _slashedUser);
     vm.assume(_slashedUser != _notSlashedUser);
 
     // bound input parameters
-    _pledgesForDispute = bound(_pledgesForDispute, 1, type(uint64).max);
-    _pledgesAgainstDispute = bound(_pledgesAgainstDispute, 1, type(uint64).max);
-    _amount = bound(_amount, type(uint16).max, type(uint64).max);
-    _bondSize = bound(_bondSize, 1, type(uint16).max);
+    _pledgesForDispute = bound(_pledgesForDispute, 1, type(uint64).max - 1);
+    _pledgesAgainstDispute = bound(_pledgesAgainstDispute, 1, type(uint64).max - 1);
+    _amount = bound(_amount, type(uint16).max, type(uint64).max - 1);
+    _bondSize = bound(_bondSize, 1, type(uint16).max - 1);
 
     _setUpHappyPath(_pledgesForDispute, _pledgesAgainstDispute, _bondSize, _amount);
 
@@ -907,15 +905,13 @@ contract HorizonAccountingExtension_Unit_ClaimEscalationReward is HorizonAccount
     uint256 _bondSize,
     uint256 _amount
   ) public {
-    vm.assume(_amount >= _bondSize);
-
     vm.assume(_pledger != _slashedUser);
     vm.assume(_slashedUser != _notSlashedUser);
     // bound input parameters
-    _pledgesForDispute = bound(_pledgesForDispute, 1, type(uint64).max);
-    _pledgesAgainstDispute = bound(_pledgesAgainstDispute, 1, type(uint64).max);
-    _amount = bound(_amount, type(uint16).max, type(uint64).max);
-    _bondSize = bound(_bondSize, 1, type(uint16).max);
+    _pledgesForDispute = bound(_pledgesForDispute, 1, type(uint64).max - 1);
+    _pledgesAgainstDispute = bound(_pledgesAgainstDispute, 1, type(uint64).max - 1);
+    _amount = bound(_amount, type(uint16).max, type(uint64).max - 1);
+    _bondSize = bound(_bondSize, 1, type(uint16).max - 1);
 
     _setUpHappyPath(_pledgesForDispute, _pledgesAgainstDispute, _bondSize, _amount);