Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a switch for enabling datadog security #808

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add a switch for enabling datadog security #808

merged 1 commit into from
Mar 15, 2024

Conversation

essa
Copy link
Contributor

@essa essa commented Mar 13, 2024 •
edited
Loading

Continues from #807
Datadog CWS was expensive so we want to install it to only the district really needed.
This PR adds a switch for it.

$ bcn district put-plugin -a api_key=8e53.... -a hook_priority=10 -a cws=enabled ec-staging datadog

CWS is enabled only when cws=enabled is specified.

And it also change the tag role for bastion.

@degikko
Copy link

degikko commented Mar 13, 2024

@showwin can you help us review this PR, please?

@degikko degikko requested a review from showwin March 13, 2024 06:03
showwin
showwin approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@showwin showwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@essa essa merged commit 78d18bc into master Mar 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@showwin showwin showwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@essa @degikko @showwin