This repository has been archived by the owner on May 6, 2020. It is now read-only.
feat(ingress): experimental native ingress #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding ingress support to controller Adding changes to chart to support feature Adding ingress rules for controller API, and SSH on TCP 2222 Adding ingress support in general Requires deis/workflow#732 Requires deis/builder#495 Requires deis/router#316 Technically a non breaking change, as the user must opt-in to the feature
Instead of raising HTTP exception, lets raise ServiceUnavailable Non breaking change
|
@bacongobbler, @Joshua-Anderson and @krancour are potential reviewers of this pull request based on my analysis of |
Codecov Report
@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
- Coverage 87.26% 86.63% -0.64%
==========================================
Files 44 45 +1
Lines 3887 3928 +41
Branches 675 681 +6
==========================================
+ Hits 3392 3403 +11
- Misses 327 356 +29
- Partials 168 169 +1Continue to review full report at Codecov.
|
|
full CI run for this change (with the rest of the associated ingress PR artifacts) is here: https://ci.deis.io/job/workflow-chart-e2e/1190/console |
This was referenced Mar 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1243 by patching a coercion to
bool. All credit to @kris-nova of course.Work for experimental native ingress. Run the documentation in deis/workflow#732 to see how to use the new feature.
This PR handles the changes necessary to the controller to start managing Kubernetes ingresses
Requires deis/workflow#782
Requires deis/builder#495
Requires deis/router#316