chore(ingress): Adding unit tests #1283
Conversation
|
@bacongobbler, @mboersma and @rvadim are potential reviewers of this pull request based on my analysis of |
Adding unit tests for ingress Non breaking change
|
looks like |
Fixing some formatting concerns in make test-style Non breaking change
|
Oh dang, thanks @bacongobbler they should be fixed now. |
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
+ Coverage 86.66% 87.04% +0.38%
==========================================
Files 45 45
Lines 3929 3929
Branches 681 681
==========================================
+ Hits 3405 3420 +15
+ Misses 355 338 -17
- Partials 169 171 +2Continue to review full report at Codecov.
|
| @@ -55,7 +55,7 @@ def create(self, ingress, namespace, hostname): | |||
| return response | |||
|
|
|||
| def delete(self, namespace, ingress): | |||
| url = self.api("/namespaces/{}/ingresses/{}", namespace, ingress) | |||
| url = "/apis/extensions/v1beta1/namespaces/%s/ingresses/%s" % (namespace, ingress) | |||
There was a problem hiding this comment.
good catch. I also just checked to confirm and this API endpoint is also the same for v1.5. We'll have to refactor the self.api function now that kubernetes is going with the aggregated API route, but this works for now. 👍
I'll file an issue for this.
Adding unit tests for ingress
Non breaking change
closes #1275