Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge redesign into develop #50

Merged
merged 19 commits into from
Nov 9, 2021

Conversation

johannesduesing
Copy link

Reason for this PR
We decided to reengineer parts of the delphi system to be more flexible in terms of new feature and new data. We first decided to split the ES index into multiple parts, and reduce the application to parsing POM files for now.

Changes in this PR

  • Upgrade to Scala 2.12.15 and SBT 1.5.5
  • Upgrade to latest versions of Elastic4s, AKKA, Apache Maven and OPAL
  • Removed code that was stale or not needed for the redesign
  • Switched to a new library for parsing POM files
  • Introduced PomFileReadActor for processing POM files plus unit tests
  • Adopted storage interface to store identifiers, metadata and hermes results in separate indices
  • Adopted storage maintenance interface to create three separate indices
  • Made download more flexibel, JAR file download success is now not required anymore if packaging is not set to jar
  • Improved error handling: Errors in the different phases (downloading, metadata extraction, hermes processing) are caught and stored in a separate ES index.
  • Improved handling of OPAL logging, can now be switched on or off as desired

References
Fully incorporates all functionalities proposed in PRs #49, #48 and #47

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhermann bhermann merged commit 51b6457 into delphi-hub:develop Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants