Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLPX-93224 Remove unnecessary tasks related to python3.11 added by previous os-upgrade PRs #784

Conversation

palash-gandhi
Copy link
Contributor

@palash-gandhi palash-gandhi commented Jan 23, 2025

Problem

In my previous PRs on this branch, I added python3.11 as a dependency in the bootstrap role.
Prakash pointed out that this was not required since it is already listed as a build dependency of
the virtualization package and will be installed at build time. As such, I am undoing my previous changes
around python3.11 and the associated PPA.
Prakash also pointed out that unattended-upgrades should be stopped and removed before we install
any packages.

This PR also addresses some other bugs found during testing using the resulting DE-based buildserver:

  1. appliance-build fails in this task while trying to hash a password. Apparently, ansible needs passlib to be installed. I tried installing it directly in the role but ansible still could not find the module. I tried installing it in the chroot env via apt and also via pip, none of those worked. I finally resorted to installing it via bootstrap.
  2. appliance-build fails when trying to run aws commands because it's not available in the path. It was found that snapd is not installed on DE-based buildservers and is in fact installed via a dependency by the bootstrap role. The bootstrap role then goes on to install aws-cli via snap but the Jenkins job continues to use the same shell which is why the path is not updated. When I tried to update the path and run the job, I realized that snap didn't allow the aws command to run because the home directory on a DE-based buildserver is not in /home:
delphix@ip-10-110-219-152:~$ aws
Sorry, home directories outside of /home needs configuration.
See https://forum.snapcraft.io/t/11209 for details.

I finally resorted to installing awscli via pip, system-wide.

Testing Done

https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build/job/os-upgrade/job/pre-push/137/console

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/c08c00a7-d9c0-4eb6-8d52-14c21927eb2b branch 4 times, most recently from ae6a2cc to 3709051 Compare January 23, 2025 23:12
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/c08c00a7-d9c0-4eb6-8d52-14c21927eb2b branch 2 times, most recently from 75e5b5d to dfd3f39 Compare January 24, 2025 17:54
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/c08c00a7-d9c0-4eb6-8d52-14c21927eb2b branch from dfd3f39 to aa2a108 Compare January 24, 2025 18:14
@palash-gandhi palash-gandhi marked this pull request as ready for review January 24, 2025 19:14
Copy link
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@palash-gandhi palash-gandhi merged commit 51591c9 into os-upgrade Jan 24, 2025
9 of 10 checks passed
@palash-gandhi palash-gandhi deleted the dlpx/pr/palash-gandhi/c08c00a7-d9c0-4eb6-8d52-14c21927eb2b branch January 24, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants