Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nuget package name and delta-rs version #78

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Conversation

mightyshazam
Copy link
Collaborator

  • pinned delta-rs at v0.20
  • updated package name to Delta.Net

Copy link

github-actions bot commented Sep 27, 2024

LCOV of commit c79e023 during Continuous Integration #137

Summary coverage rate:
  lines......: 90.7% (759 of 837 lines)
  functions..: 90.8% (168 of 185 functions)
  branches...: 76.2% (144 of 189 branches)

Files changed coverage rate: n/a

@mdrakiburrahman
Copy link
Collaborator

FYI - many files seem to have a hidden CRLF-type change that may have snuck in, makes it a bit harder to review the diffs

@mdrakiburrahman mdrakiburrahman mentioned this pull request Sep 29, 2024
@mightyshazam
Copy link
Collaborator Author

FYI - many files seem to have a hidden CRLF-type change that may have snuck in, makes it a bit harder to review the diffs

I ran dotnet format and got an unpleasant surprise. However, there is only one change in the .net code. That change was to change table configuration from Dictionary<string, string?> to Dictionary<string, string>. All of the other changes are in the rust code and the .github folder

@mightyshazam mightyshazam enabled auto-merge (squash) September 30, 2024 15:46
@mdrakiburrahman
Copy link
Collaborator

mdrakiburrahman commented Sep 30, 2024

Makes sense!

One way we could solve the problem by enforcing linting in future for PR's we can setup dotnet format against it in the CI pipeline, and fail on untracked files (by comparing the git hashes of what the author put up).

(This way, whatever is in main is always linted).

Copy link

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mightyshazam mightyshazam merged commit 89255fe into main Sep 30, 2024
5 checks passed
@mightyshazam mightyshazam deleted the nuget-delta-net branch September 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants