Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make ITable async #95

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

mdrakiburrahman
Copy link
Collaborator

@mdrakiburrahman mdrakiburrahman commented Oct 24, 2024

Why this change is needed

This PR makes a couple Kernel based read methods synchronous to asynchronous, which makes the public facing interface - DeltaLake.Interfaces.ITable - completely asynchronous.

See convo here for more context.

Closes issues:

How

  • A SyncToAsyncShim that wraps any typed delegate

Test

  • Ran unit tests

  • Ran example app:

    image

@mdrakiburrahman mdrakiburrahman marked this pull request as ready for review October 24, 2024 13:30
@mdrakiburrahman mdrakiburrahman merged commit f8dd070 into main Oct 29, 2024
5 checks passed
@mdrakiburrahman mdrakiburrahman deleted the dev/mdrakiburrahman/async-interface branch October 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make StorageOptions editable in TableOptions Make Kernel FFI calls async
2 participants