Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update snapshot after conflict check #3205

Merged

Conversation

ion-elgreco
Copy link
Collaborator

Description

Currently with multiple retries we would conflict check the same versions because our starting point (read_snapshot) is never updated after conflict resolution, this could be costly with many concurrent writers.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Feb 11, 2025
@ion-elgreco ion-elgreco force-pushed the fix/advance_after_conflict_check branch from eef5f72 to 8df1889 Compare February 11, 2025 11:03
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (da8327d) to head (d1786fe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/transaction/mod.rs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3205      +/-   ##
==========================================
+ Coverage   72.31%   72.32%   +0.01%     
==========================================
  Files         138      138              
  Lines       45751    45754       +3     
  Branches    45751    45754       +3     
==========================================
+ Hits        33083    33090       +7     
- Misses      10579    10581       +2     
+ Partials     2089     2083       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco force-pushed the fix/advance_after_conflict_check branch from 8df1889 to 0cec998 Compare February 14, 2025 16:32
rtyler
rtyler previously approved these changes Feb 18, 2025
@ion-elgreco ion-elgreco added this pull request to the merge queue Feb 18, 2025
@rtyler rtyler removed this pull request from the merge queue due to a manual request Feb 18, 2025
@rtyler rtyler enabled auto-merge February 18, 2025 13:54
@ion-elgreco ion-elgreco force-pushed the fix/advance_after_conflict_check branch from e2b887c to 3aa135a Compare February 18, 2025 15:27
@ion-elgreco
Copy link
Collaborator Author

@rtyler could you re-approve? : )

@rtyler rtyler added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@ion-elgreco ion-elgreco added this pull request to the merge queue Feb 18, 2025
Merged via the queue into delta-io:main with commit 44c104b Feb 18, 2025
23 checks passed
@ion-elgreco ion-elgreco deleted the fix/advance_after_conflict_check branch February 18, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants