-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update snapshot after conflict check #3205
Merged
ion-elgreco
merged 2 commits into
delta-io:main
from
ion-elgreco:fix/advance_after_conflict_check
Feb 18, 2025
Merged
fix: update snapshot after conflict check #3205
ion-elgreco
merged 2 commits into
delta-io:main
from
ion-elgreco:fix/advance_after_conflict_check
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eef5f72
to
8df1889
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
==========================================
+ Coverage 72.31% 72.32% +0.01%
==========================================
Files 138 138
Lines 45751 45754 +3
Branches 45751 45754 +3
==========================================
+ Hits 33083 33090 +7
- Misses 10579 10581 +2
+ Partials 2089 2083 -6 ☔ View full report in Codecov by Sentry. |
8df1889
to
0cec998
Compare
rtyler
previously approved these changes
Feb 18, 2025
Signed-off-by: Ion Koutsouris <[email protected]>
e2b887c
to
3aa135a
Compare
@rtyler could you re-approve? : ) |
rtyler
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently with multiple retries we would conflict check the same versions because our starting point (read_snapshot) is never updated after conflict resolution, this could be costly with many concurrent writers.