Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small improvements to deno example #77

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

small improvements to deno example #77

wants to merge 5 commits into from

Conversation

Simon-Laux
Copy link
Contributor

@Simon-Laux Simon-Laux commented Dec 24, 2024 •
edited
Loading

  • mention deno example dc core version in readme
  • add dc data dir to gitignore
  • move to typescript, because deno natively supports it
  • remove node:process dependency (from the bot, it is still used by @deltachat/stdio-rpc-server)

@Simon-Laux Simon-Laux requested a review from link2xt December 24, 2024 19:52
@link2xt
Copy link
Contributor

link2xt commented Dec 24, 2024

This closes #75

@Simon-Laux
Copy link
Contributor Author

Simon-Laux commented Dec 24, 2024 •
edited
Loading

This closes #75

No, because that is done in the dependency, I only replaced it's usage for exiting and for the getting the environment variables.

The child process dependency is still in core repo/@deltachat/stdio-rpc-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@link2xt link2xt link2xt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simon-Laux @link2xt