Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak asking for "disable battery optimisations" #3075

Merged
merged 2 commits into from
May 21, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented May 20, 2024

do not ask for "disable battery optimisations" when all accounts are chatmail and we got a push token.

with chatmail, we reduced the number of questions from three to only one (or zero for android<=12):

Screenshot 2024-05-21 at 01 16 19

if classic mail is used, the following questions follow - either for the first account, but also anytime later when a non-chatmail is added:

Screenshot 2024-05-21 at 01 16 30 Screenshot 2024-05-21 at 01 16 35

the push token, however, is got unconditionally from the other states - it is a cheap call, the device is connected to the PUSH server anyways and we want to leave it up to core what to do with it

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s r10s requested a review from adbenitez May 20, 2024 23:24
@r10s r10s marked this pull request as ready for review May 20, 2024 23:25
@r10s r10s added the notify label May 20, 2024
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s r10s merged commit 04031eb into main May 21, 2024
2 checks passed
@r10s r10s deleted the r10s/tweak-ask-battery-optim branch May 21, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants