Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated half-camera dependency #3582

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

adbenitez
Copy link
Member

the half-camera dependency is marked as deprecated and archived, unmaintained since 11 years ago, see: https://github.com/JakeWharton/NineOldAndroids

since a long while we switched to using system camera by default and option was buried in advanced settings

@adbenitez adbenitez requested review from r10s and Hocuri February 4, 2025 17:43
Copy link

github-actions bot commented Feb 4, 2025

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s
Copy link
Member

r10s commented Feb 4, 2025

wasn't there a report that on some system the "camera activity" did not work but the "half camera" did?

iirc, we said, that was a bug in the OS that time, but that could strike back now. but, yeah, on OS where the "camera activity" is broken, probably much more things are questionable :)

@adbenitez
Copy link
Member Author

adbenitez commented Feb 4, 2025

That was on CalyxOS, and it was fixed long ago, it is kind of a hacky system not your stock room, in any case it is not in the hand of Delta Chat to fix broken systems shipping a 11yo abandoned lib, which is not enabled by default so user has to discover it exist at all, even then user can still take pictures with camera and then select it in Delta Chat

There are closed issues related to this half-camera that we closed then precisely because we said we will remove it, in general it is not worth the efforts

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, what a great feeling to throw away code!

did not text, however

Copy link
Collaborator

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Always feels great to get rid of stuff

@adbenitez adbenitez merged commit 0eb02b5 into main Feb 5, 2025
2 checks passed
@adbenitez adbenitez deleted the adb/remove-deprecated-half-camera-dep branch February 5, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants