Increase Deployment Target to iOS 13 #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
force-pushed
the
2453-ios-12-byyyyyyeeeeee
branch
3 times, most recently
from
2b68ab3 to
e8edcc1
Compare
Also: mark more complex stuff as deprecated
When raising the deployment target to iOS 15, we'll have to replace it with UIWindowScenes and such # Conflicts: # deltachat-ios.xcodeproj/project.pbxproj
zeitschlag
force-pushed
the
2453-ios-12-byyyyyyeeeeee
branch
from
e8edcc1 to
4679929
Compare
zeitschlag
changed the title
|
getting the following error on building:
|
As both me and the CI can build that thing without getting that error I'd assume that there's something off with your local project. Have you tried Usually that build error indicates that the file is still part of Compile Sources in Build Phases, but I doublechecked: It's not there. |
|
thanks for the hint, i will double-check, code-wise, this lgtm, so we can merge in i meanwhile also created deltachat/deltachat-pages#1023 to update the requirements shown on https://delta.chat |
r10s
approved these changes
Jan 3, 2025
r10s
added a commit
that referenced
this pull request
Jan 20, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
r10s
added a commit
that referenced
this pull request
Jan 20, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
r10s
added a commit
that referenced
this pull request
Jan 22, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
r10s
added a commit
that referenced
this pull request
Jan 22, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the deployment target to iOS 13. It fixes most warnings (except #2471, which can be done in a subsequent PR, as discussed), removes
@availables (in our code),Oh, the overall LOC increased as the pods got updated, so please feel free to ignore that entire folder.