Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Encore une tentative d'améliorer la perf de la tache de migration des champs #11276

Merged

Conversation

tchak
Copy link
Member

@tchak tchak commented Jan 30, 2025

  • En lecture, on ne fait que des pluck (sauf pour charger les types de champ répétition)
  • En écriture, on fait juste un delete_all et un insert_all

Je sais que c'est dur à lire... Désolé. J'ai essayé de commenter au mieux

@tchak tchak changed the title Encore une tentative d'améliorer la perf de la tache de migration des champs [Tech] Encore une tentative d'améliorer la perf de la tache de migration des champs Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.46%. Comparing base (6b19d0b) to head (0aa836c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...migrate_non_fillable_and_repetition_champs_task.rb 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11276   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files        1212     1212           
  Lines       26680    26683    +3     
  Branches     5049     5051    +2     
=======================================
+ Hits        22534    22537    +3     
  Misses       4146     4146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak force-pushed the fix-repetition-migration-task-again branch from 448a9dd to da1ba89 Compare January 30, 2025 10:14
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que ton truc marche et j'ai une contre proposition qui me semble plus simple. A voir.

Voir aussi si ça vaut le coup de cacher (par redis) le résultat des opérations qui s'effectuent au niveau de la révision et qui seraient identique par dossier.

@tchak tchak force-pushed the fix-repetition-migration-task-again branch from da1ba89 to 0aa836c Compare February 13, 2025 10:38
@tchak tchak added this pull request to the merge queue Feb 13, 2025
Merged via the queue into demarches-simplifiees:main with commit 085dec5 Feb 13, 2025
18 checks passed
@tchak tchak deleted the fix-repetition-migration-task-again branch February 13, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants