Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Usager naviguant au clavier sur mobile, je veux que la prise de focus soit toujours visible #11277

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

inseo
Copy link
Contributor

@inseo inseo commented Jan 30, 2025

Le message d'enregistrement n'obstrue plus la prise de focus

Fix partiellement #11266

Après

visibilite_focus-OK.mp4

Avant

visibilite_focus-KO.mp4

En version mobile, les messages d'aide ne remontent plus à côté de l'encart indiquant la mise à jour du champ

Après

Avant

@@ -73,5 +73,15 @@
}

html.scroll-margins-for-sticky-footer {
scroll-padding: 0 0 100px 0;
@media (max-width: $two-columns-breakpoint) {
scroll-padding-bottom: 9.5rem;
Copy link
Contributor Author

@inseo inseo Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La valeur est exprimée en rem, pour que l'espace s'ajuste lorsque la taille de police est modifiée.

@inseo inseo self-assigned this Jan 30, 2025
@inseo inseo changed the title ETQ Usager naviguant au clavier sur mobile, je veux que la prise de focus soit toujours visible #11266 ETQ Usager naviguant au clavier sur mobile, je veux que la prise de focus soit toujours visible Jan 30, 2025
@inseo inseo removed their assignment Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (1830da0) to head (eb66efc).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11277   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files        1212     1212           
  Lines       26692    26692           
  Branches     5054     5054           
=======================================
  Hits        22545    22545           
  Misses       4147     4147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inseo inseo force-pushed the a11y-scroll-padding branch 2 times, most recently from 7c7a857 to ad12693 Compare January 31, 2025 09:48
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL scroll-padding

@inseo inseo force-pushed the a11y-scroll-padding branch from ad12693 to eb66efc Compare February 13, 2025 09:00
@inseo inseo enabled auto-merge February 13, 2025 09:08
@inseo inseo added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 6b19d0b Feb 13, 2025
18 checks passed
@inseo inseo deleted the a11y-scroll-padding branch February 13, 2025 09:17
@inseo inseo self-assigned this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Communiqué, ou a ne pas communiqué
Development

Successfully merging this pull request may close these issues.

2 participants