pr fixes

demergent-labs · Aug 30, 2024 · e86715e · e86715e
1 parent 4fc4061
commit e86715e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.github/actions/should_release/action.yml b/.github/actions/should_release/action.yml
@@ -1,10 +1,10 @@
 # TODO I feel like the wording on this is a little clunky and/or ethereal.
 # TODO we have is release vs should release and I don't feel like it's clear what the answer is
 name: Should release
-description: Determines if the current workflow should spawn a something that Jordan can figure out the wording for
+description: Determines if the current pull request is for testing or for starting a release
 outputs:
     should_release:
-        description: Returns true if this branch needs should spawn a something that Jordan can figure out the wording for, otherwise false
+        description: Returns true if this branch should start a release, otherwise false
         value: ${{ steps.determine_should_release.outputs.should_release }}
 runs:
     using: composite
@@ -16,10 +16,10 @@ runs:
               BRANCH_NAME="${{ github.head_ref }}"
               RELEASE_VERSION="${BRANCH_NAME:9}"
               COMMIT_MESSAGE=$(git log -1 --pretty=format:"%s")
-              IS_RELEASE="${{ contains(github.head_ref, 'release--') }}"
+              IS_RELEASE_BRANCH_PR="${{ contains(github.head_ref, 'release--') }}"
 
               SHOULD_RELEASE="false"
-              if [[ $IS_RELEASE == "true" && "$COMMIT_MESSAGE" == "azle-bot automated release $RELEASE_VERSION" ]]; then
+              if [[ $IS_RELEASE_BRANCH_PR == "true" && "$COMMIT_MESSAGE" == "azle-bot automated release $RELEASE_VERSION" ]]; then
                   SHOULD_RELEASE="true"
               fi
 

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,7 +10,7 @@ on:
             - main
     pull_request: # Runs on pull requests to any branch
 env:
-    IS_RELEASE: ${{ contains(github.head_ref, 'release--') }}
+    IS_RELEASE_BRANCH_PR: ${{ contains(github.head_ref, 'release--') }}
     IS_FEATURE_BRANCH_PR: ${{ !contains(github.head_ref, 'release--') }}
     DFX_VERSION: 0.21.0
     NODE_VERSION: 20
@@ -129,12 +129,12 @@ jobs:
               shell: bash -l {0}
 
             - name: Start dfx
-              if: ${{ !env.IS_RELEASE }}
+              if: ${{ env.IS_FEATURE_BRANCH_PR }}
               working-directory: ${{ matrix.tests.path }}
               run: dfx start --clean --background --host 127.0.0.1:8000 --artificial-delay 0
 
             - name: Start dfx with artifcial delay
-              if: ${{ env.IS_RELEASE }}
+              if: ${{ env.IS_RELEASE_BRANCH_PR }}
               working-directory: ${{ matrix.tests.path }}
               run: dfx start --clean --background --host 127.0.0.1:8000