Read me prop tests #2177
Read me prop tests #2177
Conversation
bdemann
force-pushed
the
readme_prop_tests
branch
from
2927779
to
425740a
Compare
There was a problem hiding this comment.
Probably remove this as we don't already have property tests for timers
There was a problem hiding this comment.
We should have a design discussion about what these property tests should look like
There was a problem hiding this comment.
The more I think about it the more I think that it's good enough with tests/end_to_end/candid_rpc/class_syntax/timers/. The timers tests is a very robust little test. I really don't see how adding arbitrariness to these timers will be feasible, reasonable, or worth while (as per #2185 (comment))
So let's talk about it, if afterwards we still want to make prop tests for the timer functions then we can delete this file and merge this pr, otherwise we can leave it and merge this pr.
There was a problem hiding this comment.
Analyze the current property test for this and decide if we already have enough coverage
bdemann
force-pushed
the
readme_prop_tests
branch
from
425740a
to
e0b5c41
Compare
These prop tests we are going to pass on for right now because they are sufficiently covered in the e2e tests