Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump rquickjs from 0.6.2 to 0.8.1 #2384

Merged
merged 4 commits into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 9 additions & 34 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified canister_templates/experimental.wasm
Binary file not shown.
Binary file modified canister_templates/stable.wasm
Binary file not shown.
2 changes: 1 addition & 1 deletion examples/stable/test/property/ic_api/chunk/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ async function sum(loops: number, shouldChunk: boolean): Promise<void> {
for (let i = 0; i < loops; i++) {
_sum += (i % 100) * (i % 100);

if (shouldChunk && i % 15_000_000 === 0) {
if (shouldChunk && i % 14_000_000 === 0) {
await chunk();
}
}
Expand Down
3 changes: 3 additions & 0 deletions examples/stable/test/property/ic_api/chunk/test/tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ export function getTests(): Test {
);
});

// TODO this test will simply hang if it fails because timers don't throw any errors that we can catch
// TODO we would need to use the canister logs somehow to check if the timer has hit its instruction limit
// TODO but see this issue: https://forum.dfinity.org/t/no-instruction-limit-hit-canister-logs-within-timer/39518
it('should not hit the instruction limit with chunking in a timer', async () => {
const actor = await getCanisterActor<Actor>('canister');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ic-cdk-macros = "0.17.1"
ic-cdk-timers = "0.11.0"
ic-stable-structures = "0.6.7"
ic-wasi-polyfill = "0.6.4"
rquickjs = { version = "0.6.2", features = ["array-buffer", "bindgen"] }
rquickjs = { version = "0.8.1", features = ["array-buffer", "bindgen"] }
scopeguard = "1.2.0"
serde = "1.0.217"
serde_json = "1.0.134"
Expand Down
Loading