Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Msg arg data #2538

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Msg arg data #2538

wants to merge 5 commits into from
+60 −60

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jan 17, 2025 •
edited
Loading

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

@lastmjs lastmjs linked an issue Jan 17, 2025 that may be closed by this pull request
arg data should be simplified to just use bytes and match the spec for their names #2537
Open
@lastmjs lastmjs marked this pull request as ready for review January 17, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arg data should be simplified to just use bytes and match the spec for their names
1 participant
@lastmjs