Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize tests #2561

Merged
merged 11 commits into from
Jan 24, 2025
Merged

stabilize tests #2561

merged 11 commits into from
Jan 24, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Jan 22, 2025

Contributor

  • Make sure that GitHub actions doesn't have a more built-in way of automatically retrying jobs
    • It doesn't seem like it, there are some third party solutions that essentially do the same thing as we do
  • Breaking changes enumerated in the release issue
    • technically removing the deep-is dependency is a breaking change? But I didn't count it
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues
    • No issues, it's just failing dependabot prs

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly (manually test the exponential backoff and ensure each success case works after each attempt up to 5 attempts)
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

@bdemann bdemann changed the title stabilize stable b tree map equality stabilize tests Jan 22, 2025
@bdemann bdemann marked this pull request as ready for review January 22, 2025 21:22
.github/workflows/build_templates.yml Outdated Show resolved Hide resolved
test/property/test/index.ts Outdated Show resolved Hide resolved
.github/actions/npm_install/action.yml Outdated Show resolved Hide resolved
.github/actions/npm_install/action.yml Outdated Show resolved Hide resolved
.github/actions/npm_install/action.yml Outdated Show resolved Hide resolved
.github/actions/npm_install/action.yml Outdated Show resolved Hide resolved
@bdemann bdemann requested a review from lastmjs January 24, 2025 18:04
lastmjs
lastmjs previously approved these changes Jan 24, 2025
@lastmjs lastmjs merged commit f114611 into main Jan 24, 2025
372 of 373 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants