Fix AsyncValidationCE binding against asyncResult

src/FsToolkit.ErrorHandling/AsyncValidationCE.fs

@@ -139,7 +139,7 @@ module AsyncValidationCE =
     let asyncValidation = AsyncValidationBuilder()
 
 [<AutoOpen>]
-module HighPriority =
+module LowPriority =
 
     // Having members as extensions gives them lower priority in
     // overload resolution and allows skipping more type annotations.
@@ -148,15 +148,19 @@ module HighPriority =
         /// <summary>
         /// Method lets us transform data types into our internal representation.
         /// </summary>
-        member inline _.Source(s: Async<Result<'ok, 'error>>) : AsyncValidation<_, 'error> =
-            s
-            |> AsyncResult.mapError (fun e -> [ e ])
+        member inline _.Source(s: Async<Result<'ok, 'error>>) : AsyncValidation<'ok, 'error> =
+            AsyncResult.mapError List.singleton s
 
         /// <summary>
         /// Method lets us transform data types into our internal representation.
         /// </summary>
-        member inline _.Source(s: Result<'ok, 'error>) : AsyncValidation<'ok, 'error> =
-            AsyncValidation.ofResult s
+        member inline _.Source(s: Result<'ok, 'error list>) : AsyncValidation<'ok, 'error> =
+            Async.retn s
+
+[<AutoOpen>]
+module HighPriority =
+
+    type AsyncValidationBuilder with
 
         /// <summary>
         /// Method lets us transform data types into our internal representation.
@@ -168,6 +172,12 @@ module HighPriority =
                 return! AsyncValidation.ok result
             }
 
+        /// <summary>
+        /// Method lets us transform data types into our internal representation.
+        /// </summary>
+        member inline _.Source(s: Result<'ok, 'error>) : AsyncValidation<'ok, 'error> =
+            AsyncValidation.ofResult s
+
         /// <summary>
         /// Method lets us transform data types into our internal representation.
         /// </summary>
@@ -179,14 +189,3 @@ module HighPriority =
         /// Needed to allow `for..in` and `for..do` functionality
         /// </summary>
         member inline _.Source(s: #seq<_>) : #seq<_> = s
-
-[<AutoOpen>]
-module LowPriority =
-
-    type AsyncValidationBuilder with
-
-        /// <summary>
-        /// Method lets us transform data types into our internal representation.
-        /// </summary>
-        member inline _.Source(s: Validation<'ok, 'error>) : AsyncValidation<'ok, 'error> =
-            Async.retn s

tests/FsToolkit.ErrorHandling.Tests/AsyncValidationCE.fs

@@ -158,11 +158,12 @@ let ``AsyncValidationCE bind Tests`` =
         testCaseAsync "let! Error Validation"
         <| async {
             let innerData = "Foo"
-            let expected = Error [ innerData ]
+            let error = Error innerData
+            let expected = Error [ [ innerData ] ]
 
             let! actual =
                 asyncValidation {
-                    let! f = validation { return! expected }
+                    let! f = validation { return! error }
                     return f
                 }
 
@@ -448,7 +449,7 @@ let ``AsyncValidationCE applicative tests`` =
             Expect.equal actual (Ok 4) "Should be ok"
         }
 
-        testCaseAsync "Happy Path Result/Valiation"
+        testCaseAsync "Happy Path Result/Validation"
         <| async {
             let! actual =
                 asyncValidation {
@@ -487,6 +488,30 @@ let ``AsyncValidationCE applicative tests`` =
             Expect.equal actual (Ok 4) "Should be ok"
         }
 
+        testCaseAsync "Happy Path Async Result/Async Result"
+        <| async {
+            let! actual =
+                asyncValidation {
+                    let! _ =
+                        async {
+                            do! Async.Sleep(1000)
+                            printfn "Hello"
+                            return Error "Hello"
+                        }
+
+                    and! _ =
+                        async {
+                            do! Async.Sleep(1000)
+                            printfn "World"
+                            return Error "World"
+                        }
+
+                    return ()
+                }
+
+            Expect.equal actual (Ok()) "Should be ok"
+        }
+
         testCaseAsync "Fail Path Result"
         <| async {
             let expected =