add requireSomeWith #303
Open
add requireSomeWith #303
+124
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
requested changes
Jan 11, 2025
There was a problem hiding this comment.
Functions look good!
Just some nitpicks on keeping names the same.
Also would you mind adding doc comments and doc pages?
Thanks!
Co-authored-by: Jimmy Byrd <[email protected]>
Co-authored-by: Jimmy Byrd <[email protected]>
|
I can add the docs. Might take me a bit to make sure I'm careful with my copy-pasta'ing. |
|
Unintentionally closed |
TheAngryByrd
requested changes
Jan 14, 2025
| @@ -124,6 +124,10 @@ module JobResult = | |||
| option | |||
| |> Job.map (Result.requireSome error) | |||
|
|
|||
| let inline requireSomeWith ifErrorThunk option = | |||
| @@ -157,6 +157,13 @@ module AsyncResult = | |||
| value | |||
| |> Async.map (Result.requireSome error) | |||
|
|
|||
| let inline requireSomeWith | |||
| @@ -109,6 +109,10 @@ module TaskResult = | |||
| option | |||
| |> Task.map (Result.requireSome error) | |||
|
|
|||
| let inline requireSomeWith ifErrorThunk option = | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Closes #301
This adds
requireSomeWithhelpers, analogous to thedefaultWithofOptionfor types that already have arequireSomefunction.Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an
xin the boxes that apply and remove ones that don't applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
I've not yet added doc comments, as I saw some variability in coverage and not sure which is the up to date pattern to follow and how much should be documented.