Fix SSO with instance name instead of port #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a named instance instead of a port is used, Kerberos logins failed because the spn string was "MSSQLSvc@SERVER_NAME:None" instead of "MSSQLSvc@SERVER_NAME:INSTANCE_NAME".
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 93.58% 91.79% -1.80%
==========================================
Files 28 27 -1
Lines 7947 7736 -211
==========================================
- Hits 7437 7101 -336
- Misses 510 635 +125
Continue to review full report at Codecov.
|
This fixes the following error:
kerberos.GSSError: (('Unspecified GSS failure. Minor code
may provide more information', 851968), ('Server not found
in Kerberos database', -1765328377))
|
Why do you need to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a named instance instead of a port is used, Kerberos logins failed because the spn string was
"MSSQLSvc@SERVER_NAME:None" instead of "MSSQLSvc@SERVER_NAME:INSTANCE_NAME".
When "port" is None (parsed_servers[0][1]), "instance" (parsed_servers[0][2]) should be used.