fix: 🐛 disconnect equals true for one to one relationship

dennemark · Sep 23, 2024 · 43d884d · 43d884d
1 parent 7bd7083
commit 43d884d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 9 deletions.
diff --git a/src/applyDataQuery.ts b/src/applyDataQuery.ts
@@ -92,16 +92,18 @@ export function applyDataQuery(
                         const isConnection = nestedAction === 'connect' || nestedAction === 'disconnect'
 
                         tree.children[field] = { action: mutationAction, model: relationModel.type as Prisma.ModelName, children: {} }
-                        const dataQuery = applyDataQuery(abilities, nestedArgs, mutationAction, relationModel.type, tree.children[field])
-                        mutation[field][nestedAction] = dataQuery.args
-                        // connection works like a where query, so we apply it
-                        if (isConnection) {
-                            const accessibleQuery = accessibleBy(abilities, mutationAction)[relationModel.type as Prisma.ModelName]
+                        if (nestedAction !== 'disconnect' && nestedArgs !== true) {
+                            const dataQuery = applyDataQuery(abilities, nestedArgs, mutationAction, relationModel.type, tree.children[field])
+                            mutation[field][nestedAction] = dataQuery.args
+                            // connection works like a where query, so we apply it
+                            if (isConnection) {
+                                const accessibleQuery = accessibleBy(abilities, mutationAction)[relationModel.type as Prisma.ModelName]
 
-                            if (Array.isArray(mutation[field][nestedAction])) {
-                                mutation[field][nestedAction] = mutation[field][nestedAction].map((q) => applyAccessibleQuery(q, accessibleQuery))
-                            } else {
-                                mutation[field][nestedAction] = applyAccessibleQuery(mutation[field][nestedAction], accessibleQuery)
+                                if (Array.isArray(mutation[field][nestedAction])) {
+                                    mutation[field][nestedAction] = mutation[field][nestedAction].map((q) => applyAccessibleQuery(q, accessibleQuery))
+                                } else {
+                                    mutation[field][nestedAction] = applyAccessibleQuery(mutation[field][nestedAction], accessibleQuery)
+                                }
                             }
                         }
                     } else {

diff --git a/test/applyDataQuery.test.ts b/test/applyDataQuery.test.ts
@@ -125,6 +125,20 @@ describe('apply data query', () => {
         })
 
     })
+    describe('disconnect', () => {
+        it('accepts disconnect: true', () => {
+            const { can, build } = abilityBuilder()
+            can('update', 'User', {
+                id: 0
+            })
+            can('update', 'Post', {
+                id: 1
+            })
+            const result = applyDataQuery(build(), { data: { id: 1, posts: { disconnect: true } }, where: { id: 0 } }, 'update', 'User')
+            expect(result.args).toEqual({ data: { id: 1, posts: { disconnect: true } }, where: { id: 0, AND: [{ OR: [{ id: 0 }] }] } })
+            expect(result.creationTree).toEqual({ children: { posts: { children: {}, action: 'update', model: 'Post', } }, model: 'User', action: "update" })
+        })
+    })
     describe('connectOrCreate', () => {
         it('adds where and connection clause in nested connection update', () => {
             const { can, build } = abilityBuilder()